nvme: fix uninitialized prp2 value on small transfers
authorJan H. Schönherr <jschoenh@amazon.de>
Sun, 27 Aug 2017 13:56:37 +0000 (15:56 +0200)
committerSagi Grimberg <sagi@grimberg.me>
Mon, 28 Aug 2017 20:00:44 +0000 (23:00 +0300)
The value of iod->first_dma ends up as prp2 in NVMe commands. In case
there is not enough data to cross a page boundary, iod->first_dma is
never initialized and contains random data.

Comply with the NVMe specification and fill in 0 in that case.

Signed-off-by: Jan H. Schönherr <jschoenh@amazon.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/pci.c

index e6283745ecd233794731044787ec8207e4326c54..544805a2421b6be655cecbcd5889e8081a60280b 100644 (file)
@@ -555,8 +555,10 @@ static blk_status_t nvme_setup_prps(struct nvme_dev *dev, struct request *req)
        int nprps, i;
 
        length -= (page_size - offset);
-       if (length <= 0)
+       if (length <= 0) {
+               iod->first_dma = 0;
                return BLK_STS_OK;
+       }
 
        dma_len -= (page_size - offset);
        if (dma_len) {