staging: wilc1000: linux_sdio_probe: use return value
authorGlen Lee <glen.lee@atmel.com>
Mon, 21 Dec 2015 05:18:28 +0000 (14:18 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 21 Dec 2015 21:20:04 +0000 (13:20 -0800)
Return ret from wilc_netdev_init instead of -1 for proper error handling.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wilc1000/linux_wlan_sdio.c

index e25811d2c5b59e6ded754686ef226930e21ac185..4b9cb556203874d09d4bf188ae62b8b3e0214f93 100644 (file)
@@ -91,7 +91,7 @@ static int linux_sdio_probe(struct sdio_func *func,
                            const struct sdio_device_id *id)
 {
        struct wilc *wilc;
-       int gpio;
+       int gpio, ret;
 
        gpio = -1;
        if (IS_ENABLED(CONFIG_WILC1000_HW_OOB_INTR)) {
@@ -101,10 +101,11 @@ static int linux_sdio_probe(struct sdio_func *func,
        }
 
        dev_dbg(&func->dev, "Initializing netdev\n");
-       if (wilc_netdev_init(&wilc, &func->dev, HIF_SDIO, gpio,
-                            &wilc_hif_sdio)) {
+       ret = wilc_netdev_init(&wilc, &func->dev, HIF_SDIO, gpio,
+                            &wilc_hif_sdio);
+       if (ret) {
                dev_err(&func->dev, "Couldn't initialize netdev\n");
-               return -1;
+               return ret;
        }
        sdio_set_drvdata(func, wilc);
        wilc->dev = &func->dev;