[media] saa7134: use pr_warn() on some places where no KERN_foo were used
authorMauro Carvalho Chehab <mchehab@osg.samsung.com>
Thu, 30 Apr 2015 10:15:20 +0000 (07:15 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Wed, 13 May 2015 13:08:33 +0000 (10:08 -0300)
On a few places, mostly during board detection, some printk()
macros were called without especifying any message level.

Those are actually warnings. So, use pr_warn() for them.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/pci/saa7134/saa7134-cards.c
drivers/media/pci/saa7134/saa7134-core.c

index 5b81157a5003fa0176e9bc528f617f4a55f2802b..abbeeb9231147e12664a3af492f07065bf201c78 100644 (file)
@@ -7159,10 +7159,10 @@ MODULE_DEVICE_TABLE(pci, saa7134_pci_tbl);
 
 static void board_flyvideo(struct saa7134_dev *dev)
 {
-       printk("%s: there are different flyvideo cards with different tuners\n"
-              "%s: out there, you might have to use the tuner=<nr> insmod\n"
-              "%s: option to override the default value.\n",
-              dev->name, dev->name, dev->name);
+       pr_warn("%s: there are different flyvideo cards with different tuners\n"
+               "%s: out there, you might have to use the tuner=<nr> insmod\n"
+               "%s: option to override the default value.\n",
+               dev->name, dev->name, dev->name);
 }
 
 static int saa7134_xc2028_callback(struct saa7134_dev *dev,
@@ -7513,10 +7513,10 @@ int saa7134_board_init1(struct saa7134_dev *dev)
                dev->has_remote = SAA7134_REMOTE_GPIO;
                break;
        case SAA7134_BOARD_MD5044:
-               printk("%s: seems there are two different versions of the MD5044\n"
-                      "%s: (with the same ID) out there.  If sound doesn't work for\n"
-                      "%s: you try the audio_clock_override=0x200000 insmod option.\n",
-                      dev->name,dev->name,dev->name);
+               pr_warn("%s: seems there are two different versions of the MD5044\n"
+                       "%s: (with the same ID) out there.  If sound doesn't work for\n"
+                       "%s: you try the audio_clock_override=0x200000 insmod option.\n",
+                       dev->name,dev->name,dev->name);
                break;
        case SAA7134_BOARD_CINERGY400_CARDBUS:
                /* power-up tuner chip */
@@ -7641,10 +7641,10 @@ int saa7134_board_init1(struct saa7134_dev *dev)
                dev->has_remote = SAA7134_REMOTE_I2C;
                break;
        case SAA7134_BOARD_AVERMEDIA_A169_B:
-               printk("%s: %s: dual saa713x broadcast decoders\n"
-                      "%s: Sorry, none of the inputs to this chip are supported yet.\n"
-                      "%s: Dual decoder functionality is disabled for now, use the other chip.\n",
-                      dev->name,card(dev).name,dev->name,dev->name);
+               pr_warn("%s: %s: dual saa713x broadcast decoders\n"
+                       "%s: Sorry, none of the inputs to this chip are supported yet.\n"
+                       "%s: Dual decoder functionality is disabled for now, use the other chip.\n",
+                       dev->name,card(dev).name,dev->name,dev->name);
                break;
        case SAA7134_BOARD_AVERMEDIA_M102:
                /* enable tuner */
@@ -7790,7 +7790,7 @@ int saa7134_board_init2(struct saa7134_dev *dev)
                if (board == dev->board)
                        break;
                dev->board = board;
-               printk("%s: board type fixup: %s\n", dev->name,
+               pr_warn("%s: board type fixup: %s\n", dev->name,
                saa7134_boards[dev->board].name);
                dev->tuner_type = saa7134_boards[dev->board].tuner_type;
 
@@ -8047,7 +8047,7 @@ int saa7134_board_init2(struct saa7134_dev *dev)
                        msg.len = ARRAY_SIZE(buffer[0]);
                        if (i2c_transfer(&dev->i2c_adap, &msg, 1) != 1)
                                pr_warn("%s: Unable to enable tuner(%i).\n",
-                                       dev->name, i);
+                                       dev->name, i);
                }
                break;
        }
index c206148f816bb773436041739cfb78d4927ed777..83dbb443214e2a6d414709fed9dad5aed7408b56 100644 (file)
@@ -947,7 +947,7 @@ static int saa7134_initdev(struct pci_dev *pci_dev,
               dev->pci_lat,(unsigned long long)pci_resource_start(pci_dev,0));
        pci_set_master(pci_dev);
        if (!pci_dma_supported(pci_dev, DMA_BIT_MASK(32))) {
-               printk("%s: Oops: no 32bit PCI DMA ???\n",dev->name);
+               pr_warn("%s: Oops: no 32bit PCI DMA ???\n", dev->name);
                err = -EIO;
                goto fail1;
        }