drm: Use the driver's gem_object_free function from CMA helpers.
authorEric Anholt <eric@anholt.net>
Tue, 15 Dec 2015 00:26:26 +0000 (16:26 -0800)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 15 Dec 2015 09:23:44 +0000 (10:23 +0100)
VC4 wraps the CMA objects in its own structures, so it needs to do its
own teardown (waiting for GPU to finish, updating bo_stats tracking).
The other CMA drivers are using drm_gem_cma_free_object as their
gem_free_object, so this should be a no-op for them.

Signed-off-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/drm_fb_cma_helper.c
drivers/gpu/drm/drm_gem_cma_helper.c

index b7d5b848d2f89a535e22b6ea9b7987e7e3b9bea8..5543fa806aec1888deb2d96e3ea351bfdf17a1e8 100644 (file)
@@ -266,7 +266,7 @@ static int drm_fbdev_cma_create(struct drm_fb_helper *helper,
        fbi = drm_fb_helper_alloc_fbi(helper);
        if (IS_ERR(fbi)) {
                ret = PTR_ERR(fbi);
-               goto err_drm_gem_cma_free_object;
+               goto err_gem_free_object;
        }
 
        fbdev_cma->fb = drm_fb_cma_alloc(dev, &mode_cmd, &obj, 1);
@@ -299,8 +299,8 @@ static int drm_fbdev_cma_create(struct drm_fb_helper *helper,
 
 err_fb_info_destroy:
        drm_fb_helper_release_fbi(helper);
-err_drm_gem_cma_free_object:
-       drm_gem_cma_free_object(&obj->base);
+err_gem_free_object:
+       dev->driver->gem_free_object(&obj->base);
        return ret;
 }
 
index 0f7b00ba57daab4b2d4ddb26f165027ef14a9ee3..e5df53b6e229ff0348541eeaa921acc6cf4700ef 100644 (file)
@@ -121,7 +121,7 @@ struct drm_gem_cma_object *drm_gem_cma_create(struct drm_device *drm,
        return cma_obj;
 
 error:
-       drm_gem_cma_free_object(&cma_obj->base);
+       drm->driver->gem_free_object(&cma_obj->base);
        return ERR_PTR(ret);
 }
 EXPORT_SYMBOL_GPL(drm_gem_cma_create);
@@ -171,7 +171,7 @@ drm_gem_cma_create_with_handle(struct drm_file *file_priv,
        return cma_obj;
 
 err_handle_create:
-       drm_gem_cma_free_object(gem_obj);
+       drm->driver->gem_free_object(gem_obj);
 
        return ERR_PTR(ret);
 }