ath10k: add missing mutex unlock on failpath
authorMichal Kazior <michal.kazior@tieto.com>
Wed, 19 Aug 2015 11:08:53 +0000 (13:08 +0200)
committerKalle Valo <kvalo@qca.qualcomm.com>
Wed, 26 Aug 2015 08:04:26 +0000 (11:04 +0300)
Kernel would complain about leaving a held lock
after going back to userspace and would
subsequently deadlock.

Fixes: e04cafbc38c7 ("ath10k: fix peer limit enforcement")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
drivers/net/wireless/ath/ath10k/mac.c

index 9bca37820848714da3a3bab479328a7c743e91c7..64674c955d44745976beb2ee9e9d1639fe067bf0 100644 (file)
@@ -4144,7 +4144,8 @@ static int ath10k_add_interface(struct ieee80211_hw *hw,
 
        if (ar->num_peers >= ar->max_num_peers) {
                ath10k_warn(ar, "refusing vdev creation due to insufficient peer entry resources in firmware\n");
-               return -ENOBUFS;
+               ret = -ENOBUFS;
+               goto err;
        }
 
        if (ar->free_vdev_map == 0) {