net: batch of last_rx update avoidance in ethernet drivers.

None of those drivers uses last_rx for its own needs.

See 4dc89133f49b8cfd77ba7e83f5960aed63aaa99e ("net: add a comment on
netdev->last_rx") for reference.

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: Wingman Kwok <w-kwok2@ti.com>
Cc: Murali Karicheri <m-karicheri2@ti.com>
Cc: Chris Metcalf <cmetcalf@tilera.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
index db84ddcfec8464191a3edcccfd87c869ac1c5a7c..d45fd1b1fb7d5a3215475397e91ff9c6c3c5b70a 100644 (file)
--- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
@@ -2072,7 +2072,6 @@ skip_data:
                skb_record_rx_queue(skb, channel->queue_index);
                skb_mark_napi_id(skb, napi);
 
-               netdev->last_rx = jiffies;
                napi_gro_receive(napi, skb);
 
 next_packet:

diff --git a/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c b/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c
index 0ffdcd381fddde21f3d56edeeaeeef22f589ff4c..a5e077eac99a3b8292fd5355c142733dccbf8f89 100644 (file)
--- a/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c
+++ b/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c
@@ -500,7 +500,6 @@ static int hix5hd2_rx(struct net_device *dev, int limit)
                napi_gro_receive(&priv->napi, skb);
                dev->stats.rx_packets++;
                dev->stats.rx_bytes += skb->len;
-               dev->last_rx = jiffies;
 next:
                pos = dma_ring_incr(pos, RX_DESC_NUM);
        }

diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
index 4bd3a80aba82998bba343a1870b2d21f59bca4e0..0b4a7be2c7d2b21f2286732218c0cbb2f2bb61b2 100644 (file)
--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
@@ -1688,7 +1688,6 @@ static int i40e_clean_rx_irq_ps(struct i40e_ring *rx_ring, int budget)
                skb_mark_napi_id(skb, &rx_ring->q_vector->napi);
                i40e_receive_skb(rx_ring, skb, vlan_tag);
 
-               rx_ring->netdev->last_rx = jiffies;
                rx_desc->wb.qword1.status_error_len = 0;
 
        } while (likely(total_rx_packets < budget));
@@ -1821,7 +1820,6 @@ static int i40e_clean_rx_irq_1buf(struct i40e_ring *rx_ring, int budget)
 #endif
                i40e_receive_skb(rx_ring, skb, vlan_tag);
 
-               rx_ring->netdev->last_rx = jiffies;
                rx_desc->wb.qword1.status_error_len = 0;
        } while (likely(total_rx_packets < budget));
 

diff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c
index b077e02a0cc7ac8f67ad90560cf990f8f7a66277..3ef23091439f72d90879acd3f820f15c71206127 100644 (file)
--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c
@@ -1156,7 +1156,6 @@ static int i40e_clean_rx_irq_ps(struct i40e_ring *rx_ring, int budget)
                skb_mark_napi_id(skb, &rx_ring->q_vector->napi);
                i40e_receive_skb(rx_ring, skb, vlan_tag);
 
-               rx_ring->netdev->last_rx = jiffies;
                rx_desc->wb.qword1.status_error_len = 0;
 
        } while (likely(total_rx_packets < budget));
@@ -1271,7 +1270,6 @@ static int i40e_clean_rx_irq_1buf(struct i40e_ring *rx_ring, int budget)
                         : 0;
                i40e_receive_skb(rx_ring, skb, vlan_tag);
 
-               rx_ring->netdev->last_rx = jiffies;
                rx_desc->wb.qword1.status_error_len = 0;
        } while (likely(total_rx_packets < budget));
 

diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c
index 81d0f1c86d6dee1243d5d65a7e499767698844eb..becbb5f1f5a7af9a22c20761da1dcf1f7db34ec1 100644 (file)
--- a/drivers/net/ethernet/moxa/moxart_ether.c
+++ b/drivers/net/ethernet/moxa/moxart_ether.c
@@ -244,7 +244,6 @@ static int moxart_rx_poll(struct napi_struct *napi, int budget)
                napi_gro_receive(&priv->napi, skb);
                rx++;
 
-               ndev->last_rx = jiffies;
                priv->stats.rx_packets++;
                priv->stats.rx_bytes += len;
                if (desc0 & RX_DESC0_MULTICAST)

diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c
index 0a28c07361cf0621997ad66f15c57a6d55f9e7e3..5ec4ed3f6c8def7a6a6cf527cd9ac7ca73c09844 100644 (file)
--- a/drivers/net/ethernet/ti/netcp_core.c
+++ b/drivers/net/ethernet/ti/netcp_core.c
@@ -698,7 +698,6 @@ static int netcp_process_one_rx_packet(struct netcp_intf *netcp)
                }
        }
 
-       netcp->ndev->last_rx = jiffies;
        netcp->ndev->stats.rx_packets++;
        netcp->ndev->stats.rx_bytes += skb->len;
 

diff --git a/drivers/net/ethernet/tile/tilepro.c b/drivers/net/ethernet/tile/tilepro.c
index 3d8f60d9643e45c3876c910a59c0c59f5d727a7c..6f0a4495c7f33613fed7c30a76d4ad329b80f9d9 100644 (file)
--- a/drivers/net/ethernet/tile/tilepro.c
+++ b/drivers/net/ethernet/tile/tilepro.c
@@ -721,9 +721,6 @@ static bool tile_net_poll_aux(struct tile_net_cpu *info, int index)
        if (!hash_default)
                __inv_buffer(buf, len);
 
-       /* ISSUE: Is this needed? */
-       dev->last_rx = jiffies;
-
 #ifdef TILE_NET_DUMP_PACKETS
        dump_packet(buf, len, "rx");
 #endif /* TILE_NET_DUMP_PACKETS */