ANDROID: sdcardfs: Check for NULL in revalidate
authorDaniel Rosenberg <drosen@google.com>
Mon, 22 May 2017 20:23:56 +0000 (13:23 -0700)
committerDaniel Rosenberg <drosen@google.com>
Tue, 30 Jan 2018 03:40:10 +0000 (19:40 -0800)
If the inode is in the process of being evicted,
the top value may be NULL.

Signed-off-by: Daniel Rosenberg <drosen@google.com>
Bug: 38502532
Change-Id: I0b9d04aab621e0398d44d1c5dc53293106aa5f89

fs/sdcardfs/dentry.c

index a2316817971644a5c67ecfb9b839df4bb2af6ebd..e9426a61d04a416cbf3658cc314c57d5a0f402ae 100644 (file)
@@ -109,14 +109,16 @@ static int sdcardfs_d_revalidate(struct dentry *dentry, unsigned int flags)
                goto out;
 
        /* If our top's inode is gone, we may be out of date */
-       inode = d_inode(dentry);
+       inode = igrab(d_inode(dentry));
        if (inode) {
                data = top_data_get(SDCARDFS_I(inode));
-               if (data->abandoned) {
+               if (!data || data->abandoned) {
                        d_drop(dentry);
                        err = 0;
                }
-               data_put(data);
+               if (data)
+                       data_put(data);
+               iput(inode);
        }
 
 out: