drm/i915: drop i915_add_request right in front of i915_wait_request
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 11 Feb 2010 21:53:20 +0000 (22:53 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 8 Sep 2010 09:23:39 +0000 (10:23 +0100)
... take advantage of the new implicit request issuing of
i915_wait_request.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
drivers/gpu/drm/i915/i915_gem.c

index 9f13aaa7820eaf94060495042b7252beb3dc93f8..ce66f90716c787abfcde7552df7adab933421712 100644 (file)
@@ -2043,7 +2043,6 @@ i915_gpu_idle(struct drm_device *dev)
 {
        drm_i915_private_t *dev_priv = dev->dev_private;
        bool lists_empty;
-       uint32_t seqno1, seqno2;
        int ret;
 
        spin_lock(&dev_priv->mm.active_list_lock);
@@ -2058,18 +2057,17 @@ i915_gpu_idle(struct drm_device *dev)
 
        /* Flush everything onto the inactive list. */
        i915_gem_flush(dev, I915_GEM_GPU_DOMAINS, I915_GEM_GPU_DOMAINS);
-       seqno1 = i915_add_request(dev, NULL, &dev_priv->render_ring);
-       if (seqno1 == 0)
-               return -ENOMEM;
-       ret = i915_wait_request(dev, seqno1, &dev_priv->render_ring);
+
+       ret = i915_wait_request(dev,
+                               i915_gem_next_request_seqno(dev, &dev_priv->render_ring),
+                               &dev_priv->render_ring);
        if (ret)
                return ret;
 
        if (HAS_BSD(dev)) {
-               seqno2 = i915_add_request(dev, NULL, &dev_priv->bsd_ring);
-               if (seqno2 == 0)
-                       return -ENOMEM;
-               ret = i915_wait_request(dev, seqno2, &dev_priv->bsd_ring);
+               ret = i915_wait_request(dev,
+                                       i915_gem_next_request_seqno(dev, &dev_priv->bsd_ring),
+                                       &dev_priv->bsd_ring);
                if (ret)
                        return ret;
        }