rpc_pipe: rpc_dir_inode_operations can be static
authorFengguang Wu <fengguang.wu@intel.com>
Wed, 10 Jul 2013 01:17:14 +0000 (09:17 +0800)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Wed, 10 Jul 2013 01:35:27 +0000 (21:35 -0400)
Hi Jeff,

FYI, there are new sparse warnings show up in

tree:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git nfs-for-next
head:   296afe1f58d55fd56ed85daaafafcfee39f59ece
commit: 76fa66657900071016f2bae61de28f059f3f2abf [2/5] rpc_pipe: set dentry operations at d_alloc time

>> net/sunrpc/rpc_pipe.c:496:31: sparse: symbol 'rpc_dir_inode_operations' was not declared. Should it be static?

Please consider folding the attached diff :-)

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
net/sunrpc/rpc_pipe.c

index c5f6812ca06a9628ee3ad5559b7a12cf4c81d25e..61239a2cb7861ada7771855aee937a01433441af 100644 (file)
@@ -493,7 +493,7 @@ rpc_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags)
        return NULL;
 }
 
-const struct inode_operations rpc_dir_inode_operations = {
+static const struct inode_operations rpc_dir_inode_operations = {
        .lookup         = rpc_lookup,
 };