gpio: Fix return value check in xgene_gpio_probe()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Thu, 11 Sep 2014 23:12:14 +0000 (07:12 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 24 Sep 2014 08:04:28 +0000 (10:04 +0200)
In case of error, the function devm_ioremap_nocache() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-xgene.c

index f1944d496c3b4bae4210c6db4cdd165c0e97e428..150e7f1c5ae85d95efe4924b864ea80219b780d6 100644 (file)
@@ -182,8 +182,8 @@ static int xgene_gpio_probe(struct platform_device *pdev)
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        gpio->base = devm_ioremap_nocache(&pdev->dev, res->start,
                                                        resource_size(res));
-       if (IS_ERR(gpio->base)) {
-               err = PTR_ERR(gpio->base);
+       if (!gpio->base) {
+               err = -ENOMEM;
                goto err;
        }