[SCSI] hptiop: HighPoint RocketRAID 3xxx controller driver
authorHighPoint Linux Team <linux@highpoint-tech.com>
Wed, 14 Jun 2006 08:50:57 +0000 (16:50 +0800)
committerJames Bottomley <jejb@mulgrave.il.steeleye.com>
Tue, 20 Jun 2006 00:30:15 +0000 (19:30 -0500)
Updates:
- don't bypass SYNCHRONIZE_CACHE command
- return SCSI_MLQUEUE_HOST_BUSY when no free request slots
- move scsi_remove_host() to the begin of hpt_remove(), or it will
  not work after resources being released.

Signed-off-by: HighPoint Linux Team <linux@highpoint-tech.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/scsi/hptiop.c

index 8302f3ba31ce4b808238ba570c268ddf9f9dbd8e..a96751cad8cf84e131d886a3232da4093929e2af 100644 (file)
@@ -504,19 +504,10 @@ static int hptiop_queuecommand(struct scsi_cmnd *scp,
        BUG_ON(!done);
        scp->scsi_done = done;
 
-       /*
-        * hptiop_shutdown will flash controller cache.
-        */
-       if (scp->cmnd[0] == SYNCHRONIZE_CACHE)  {
-               scp->result = DID_OK<<16;
-               goto cmd_done;
-       }
-
        _req = get_req(hba);
        if (_req == NULL) {
                dprintk("hptiop_queuecmd : no free req\n");
-               scp->result = DID_BUS_BUSY << 16;
-               goto cmd_done;
+               return SCSI_MLQUEUE_HOST_BUSY;
        }
 
        _req->scp = scp;
@@ -1429,6 +1420,8 @@ static void hptiop_remove(struct pci_dev *pcidev)
 
        dprintk("scsi%d: hptiop_remove\n", hba->host->host_no);
 
+       scsi_remove_host(host);
+
        spin_lock(&hptiop_hba_list_lock);
        list_del_init(&hba->link);
        spin_unlock(&hptiop_hba_list_lock);
@@ -1448,7 +1441,6 @@ static void hptiop_remove(struct pci_dev *pcidev)
        pci_set_drvdata(hba->pcidev, NULL);
        pci_disable_device(hba->pcidev);
 
-       scsi_remove_host(host);
        scsi_host_put(host);
 }