mmc: dw_mmc: move dw_mci_reset forward to avoid declaration
authorShawn Lin <shawn.lin@rock-chips.com>
Fri, 17 Feb 2017 02:56:40 +0000 (10:56 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 24 Apr 2017 19:41:03 +0000 (21:41 +0200)
No functional change intended.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/dw_mmc.c

index 5372460d8bba0e4aeb06f30abab9257cb61a497c..e057f557ffab14a2f131e9be67f01ffe058e5b03 100644 (file)
@@ -107,7 +107,6 @@ struct idmac_desc {
 /* Each descriptor can transfer up to 4KB of data in chained mode */
 #define DW_MCI_DESC_DATA_LENGTH        0x1000
 
-static bool dw_mci_reset(struct dw_mci *host);
 static bool dw_mci_ctrl_reset(struct dw_mci *host, u32 reset);
 static int dw_mci_card_busy(struct mmc_host *mmc);
 static int dw_mci_get_cd(struct mmc_host *mmc);
@@ -1681,6 +1680,71 @@ static int dw_mci_prepare_hs400_tuning(struct mmc_host *mmc,
        return 0;
 }
 
+static bool dw_mci_reset(struct dw_mci *host)
+{
+       u32 flags = SDMMC_CTRL_RESET | SDMMC_CTRL_FIFO_RESET;
+       bool ret = false;
+
+       /*
+        * Resetting generates a block interrupt, hence setting
+        * the scatter-gather pointer to NULL.
+        */
+       if (host->sg) {
+               sg_miter_stop(&host->sg_miter);
+               host->sg = NULL;
+       }
+
+       if (host->use_dma)
+               flags |= SDMMC_CTRL_DMA_RESET;
+
+       if (dw_mci_ctrl_reset(host, flags)) {
+               /*
+                * In all cases we clear the RAWINTS register to clear any
+                * interrupts.
+                */
+               mci_writel(host, RINTSTS, 0xFFFFFFFF);
+
+               /* if using dma we wait for dma_req to clear */
+               if (host->use_dma) {
+                       u32 status;
+
+                       if (readl_poll_timeout_atomic(host->regs + SDMMC_STATUS,
+                                                     status,
+                                                     !(status & SDMMC_STATUS_DMA_REQ),
+                                                     1, 500 * USEC_PER_MSEC)) {
+                               dev_err(host->dev,
+                                       "%s: Timeout waiting for dma_req to clear during reset\n",
+                                       __func__);
+                               goto ciu_out;
+                       }
+
+                       /* when using DMA next we reset the fifo again */
+                       if (!dw_mci_ctrl_reset(host, SDMMC_CTRL_FIFO_RESET))
+                               goto ciu_out;
+               }
+       } else {
+               /* if the controller reset bit did clear, then set clock regs */
+               if (!(mci_readl(host, CTRL) & SDMMC_CTRL_RESET)) {
+                       dev_err(host->dev,
+                               "%s: fifo/dma reset bits didn't clear but ciu was reset, doing clock update\n",
+                               __func__);
+                       goto ciu_out;
+               }
+       }
+
+       if (host->use_dma == TRANS_MODE_IDMAC)
+               /* It is also recommended that we reset and reprogram idmac */
+               dw_mci_idmac_reset(host);
+
+       ret = true;
+
+ciu_out:
+       /* After a CTRL reset we need to have CIU set clock registers  */
+       mci_send_cmd(host->cur_slot, SDMMC_CMD_UPD_CLK, 0);
+
+       return ret;
+}
+
 static const struct mmc_host_ops dw_mci_ops = {
        .request                = dw_mci_request,
        .pre_req                = dw_mci_pre_req,
@@ -2844,71 +2908,6 @@ static bool dw_mci_ctrl_reset(struct dw_mci *host, u32 reset)
        return true;
 }
 
-static bool dw_mci_reset(struct dw_mci *host)
-{
-       u32 flags = SDMMC_CTRL_RESET | SDMMC_CTRL_FIFO_RESET;
-       bool ret = false;
-
-       /*
-        * Reseting generates a block interrupt, hence setting
-        * the scatter-gather pointer to NULL.
-        */
-       if (host->sg) {
-               sg_miter_stop(&host->sg_miter);
-               host->sg = NULL;
-       }
-
-       if (host->use_dma)
-               flags |= SDMMC_CTRL_DMA_RESET;
-
-       if (dw_mci_ctrl_reset(host, flags)) {
-               /*
-                * In all cases we clear the RAWINTS register to clear any
-                * interrupts.
-                */
-               mci_writel(host, RINTSTS, 0xFFFFFFFF);
-
-               /* if using dma we wait for dma_req to clear */
-               if (host->use_dma) {
-                       u32 status;
-
-                       if (readl_poll_timeout_atomic(host->regs + SDMMC_STATUS,
-                                                     status,
-                                                     !(status & SDMMC_STATUS_DMA_REQ),
-                                                     1, 500 * USEC_PER_MSEC)) {
-                               dev_err(host->dev,
-                                       "%s: Timeout waiting for dma_req to clear during reset\n",
-                                       __func__);
-                               goto ciu_out;
-                       }
-
-                       /* when using DMA next we reset the fifo again */
-                       if (!dw_mci_ctrl_reset(host, SDMMC_CTRL_FIFO_RESET))
-                               goto ciu_out;
-               }
-       } else {
-               /* if the controller reset bit did clear, then set clock regs */
-               if (!(mci_readl(host, CTRL) & SDMMC_CTRL_RESET)) {
-                       dev_err(host->dev,
-                               "%s: fifo/dma reset bits didn't clear but ciu was reset, doing clock update\n",
-                               __func__);
-                       goto ciu_out;
-               }
-       }
-
-       if (host->use_dma == TRANS_MODE_IDMAC)
-               /* It is also recommended that we reset and reprogram idmac */
-               dw_mci_idmac_reset(host);
-
-       ret = true;
-
-ciu_out:
-       /* After a CTRL reset we need to have CIU set clock registers  */
-       mci_send_cmd(host->cur_slot, SDMMC_CMD_UPD_CLK, 0);
-
-       return ret;
-}
-
 static void dw_mci_cmd11_timer(unsigned long arg)
 {
        struct dw_mci *host = (struct dw_mci *)arg;