rcu: Remove typecheck() from RCU locking wrapper functions
authorPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Thu, 11 May 2017 22:33:23 +0000 (15:33 -0700)
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Fri, 9 Jun 2017 01:52:40 +0000 (18:52 -0700)
Because raw_spin_lock_irqsave() and raw_spin_unlock_irqrestore()
both do typecheck() on their flags argument, there is no point in
duplicating this check in raw_spin_lock_irqsave_rcu_node() and
raw_spin_unlock_irqrestore_rcu_node().  This commit therefore saves
a few lines by removing this duplicated check.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
kernel/rcu/rcu.h

index 2a75beb883c807d387a83923a98bb1921256bccb..bc55b5716c37d0b652d3660383db12a4ef307567 100644 (file)
@@ -334,18 +334,14 @@ do {                                                                      \
 #define raw_spin_unlock_irq_rcu_node(p)                                        \
        raw_spin_unlock_irq(&ACCESS_PRIVATE(p, lock))
 
-#define raw_spin_lock_irqsave_rcu_node(rnp, flags)                     \
+#define raw_spin_lock_irqsave_rcu_node(p, flags)                       \
 do {                                                                   \
-       typecheck(unsigned long, flags);                                \
-       raw_spin_lock_irqsave(&ACCESS_PRIVATE(rnp, lock), flags);       \
+       raw_spin_lock_irqsave(&ACCESS_PRIVATE(p, lock), flags); \
        smp_mb__after_unlock_lock();                                    \
 } while (0)
 
-#define raw_spin_unlock_irqrestore_rcu_node(rnp, flags)                        \
-do {                                                                   \
-       typecheck(unsigned long, flags);                                \
-       raw_spin_unlock_irqrestore(&ACCESS_PRIVATE(rnp, lock), flags);  \
-} while (0)
+#define raw_spin_unlock_irqrestore_rcu_node(p, flags)                  \
+       raw_spin_unlock_irqrestore(&ACCESS_PRIVATE(p, lock), flags)     \
 
 #define raw_spin_trylock_rcu_node(p)                                   \
 ({                                                                     \