projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 681a55d)
vxlan: correctly validate VXLAN ID against VXLAN_N_VID
authorMatthias Schiffer <mschiffer@universe-factory.net>
Thu, 23 Feb 2017 16:19:41 +0000 (17:19 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 24 Feb 2017 16:42:55 +0000 (11:42 -0500)
The incorrect check caused an off-by-one error: the maximum VID 0xffffff
was unusable.

Fixes: d342894c5d2f ("vxlan: virtual extensible lan")
Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
Acked-by: Jiri Benc <jbenc@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/vxlan.c patch | blob | blame | history

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 556953f5343720580a9ac44688adb07a70339a44..268c2a12e61d440c873a27c7f9ff6c4828094dfd 100644 (file)
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -2675,7 +2675,7 @@ static int vxlan_validate(struct nlattr *tb[], struct nlattr *data[])
 
        if (data[IFLA_VXLAN_ID]) {
                __u32 id = nla_get_u32(data[IFLA_VXLAN_ID]);
-               if (id >= VXLAN_VID_MASK)
+               if (id >= VXLAN_N_VID)
                        return -ERANGE;
        }