bcma: signedness bug in bcma_get_next_core()

The u32 would never be less than zero so the error handling would
break.  I changed it to s32 to match how bcma_erom_get_mst_port() is
declared.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

diff --git a/drivers/bcma/scan.c b/drivers/bcma/scan.c
index 0ea390f9aa9e75e3dfb2d18139eb670eca7f01f5..cad9948576837a53373791179b388d59276c7596 100644 (file)
--- a/drivers/bcma/scan.c
+++ b/drivers/bcma/scan.c
@@ -281,7 +281,7 @@ static int bcma_get_next_core(struct bcma_bus *bus, u32 __iomem **eromptr,
 
        /* get & parse master ports */
        for (i = 0; i < ports[0]; i++) {
-               u32 mst_port_d = bcma_erom_get_mst_port(bus, eromptr);
+               s32 mst_port_d = bcma_erom_get_mst_port(bus, eromptr);
                if (mst_port_d < 0)
                        return -EILSEQ;
        }