selftests/powerpc: Fix "no_handler" EBB selftest
authorAthira Rajeev <atrajeev@linux.vnet.ibm.com>
Tue, 25 May 2021 13:51:42 +0000 (09:51 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:17:50 +0000 (16:17 +0200)
[ Upstream commit 45677c9aebe926192e59475b35a1ff35ff2d4217 ]

The "no_handler_test" in ebb selftests attempts to read the PMU
registers twice via helper function "dump_ebb_state". First dump is
just before closing of event and the second invocation is done after
closing of the event. The original intention of second
dump_ebb_state was to dump the state of registers at the end of
the test when the counters are frozen. But this will be achieved
with the first call itself since sample period is set to low value
and PMU will be frozen by then. Hence patch removes the
dump which was done before closing of the event.

Reported-by: Shirisha Ganta <shirisha.ganta1@ibm.com>
Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Tested-by: Nageswara R Sastry <rnsastry@linux.ibm.com <mailto:rnsastry@linux.ibm.com>>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/1621950703-1532-2-git-send-email-atrajeev@linux.vnet.ibm.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/powerpc/pmu/ebb/no_handler_test.c

index 8341d7778d5ed4cb056a77ed846d7120a3f9cd5f..87630d44fb4c7b8511246c3c6d50109afff06d57 100644 (file)
@@ -50,8 +50,6 @@ static int no_handler_test(void)
 
        event_close(&event);
 
-       dump_ebb_state();
-
        /* The real test is that we never took an EBB at 0x0 */
 
        return 0;