bpf: no need to nullify ri->map in xdp_do_redirect
authorDaniel Borkmann <daniel@iogearbox.net>
Thu, 17 Aug 2017 13:07:22 +0000 (15:07 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 17 Aug 2017 17:15:53 +0000 (10:15 -0700)
We are guaranteed to have a NULL ri->map in this branch since
we test for it earlier, so we don't need to reset it here.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/filter.c

index e9f8dcef6c57cf237ab5798da96f1230684d6021..ea3ca34d0bf48bf398c0150b66de7f0cd9f1459c 100644 (file)
@@ -2568,7 +2568,6 @@ int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp,
 
        fwd = dev_get_by_index_rcu(dev_net(dev), index);
        ri->ifindex = 0;
-       ri->map = NULL;
        if (unlikely(!fwd)) {
                bpf_warn_invalid_xdp_redirect(index);
                return -EINVAL;