ext4: weed out ext4_write_super
authorArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Mon, 23 Jul 2012 00:35:31 +0000 (20:35 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 23 Jul 2012 00:35:31 +0000 (20:35 -0400)
We do not depend on VFS's '->write_super()' anymore and do not need
the 's_dirt' flag anymore, so weed out 'ext4_write_super()' and
's_dirt'.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>
fs/ext4/super.c

index 662e93e8c25b91d73ba4e0238f2bf2990fdd25b2..a2a59796cde0c6fb1dc7226b5e341b0412dddd69 100644 (file)
@@ -74,7 +74,6 @@ static const char *ext4_decode_error(struct super_block *sb, int errno,
 static int ext4_remount(struct super_block *sb, int *flags, char *data);
 static int ext4_statfs(struct dentry *dentry, struct kstatfs *buf);
 static int ext4_unfreeze(struct super_block *sb);
-static void ext4_write_super(struct super_block *sb);
 static int ext4_freeze(struct super_block *sb);
 static struct dentry *ext4_mount(struct file_system_type *fs_type, int flags,
                       const char *dev_name, void *data);
@@ -1210,7 +1209,6 @@ static const struct super_operations ext4_nojournal_sops = {
        .dirty_inode    = ext4_dirty_inode,
        .drop_inode     = ext4_drop_inode,
        .evict_inode    = ext4_evict_inode,
-       .write_super    = ext4_write_super,
        .put_super      = ext4_put_super,
        .statfs         = ext4_statfs,
        .remount_fs     = ext4_remount,
@@ -4364,7 +4362,6 @@ static int ext4_commit_super(struct super_block *sb, int sync)
        es->s_free_inodes_count =
                cpu_to_le32(percpu_counter_sum_positive(
                                &EXT4_SB(sb)->s_freeinodes_counter));
-       sb->s_dirt = 0;
        BUFFER_TRACE(sbh, "marking dirty");
        ext4_superblock_csum_set(sb, es);
        mark_buffer_dirty(sbh);
@@ -4471,13 +4468,6 @@ int ext4_force_commit(struct super_block *sb)
        return ret;
 }
 
-static void ext4_write_super(struct super_block *sb)
-{
-       lock_super(sb);
-       ext4_commit_super(sb, 1);
-       unlock_super(sb);
-}
-
 static int ext4_sync_fs(struct super_block *sb, int wait)
 {
        int ret = 0;