media: coda: Remove unbalanced and unneeded mutex unlock
authorEzequiel Garcia <ezequiel@collabora.com>
Thu, 2 May 2019 22:00:43 +0000 (18:00 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 31 Jul 2019 05:28:38 +0000 (07:28 +0200)
commit 766b9b168f6c75c350dd87c3e0bc6a9b322f0013 upstream.

The mutex unlock in the threaded interrupt handler is not paired
with any mutex lock. Remove it.

This bug has been here for a really long time, so it applies
to any stable repo.

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: stable@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/platform/coda/coda-bit.c

index f0f2175265a91d3c010753dfa5ba856b7ec57e9e..d538cd49a3ba80947b1cff6f5291ca63bc5daed6 100644 (file)
@@ -2257,7 +2257,6 @@ irqreturn_t coda_irq_handler(int irq, void *data)
        if (ctx == NULL) {
                v4l2_err(&dev->v4l2_dev,
                         "Instance released before the end of transaction\n");
-               mutex_unlock(&dev->coda_mutex);
                return IRQ_HANDLED;
        }