[media] tuner/xc2028: Add I2C flush callback
authorThierry Reding <thierry.reding@avionic-design.de>
Thu, 4 Aug 2011 07:13:59 +0000 (04:13 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 31 Aug 2011 18:03:22 +0000 (15:03 -0300)
When loading the firmware, complete each chunk by sending an I2C flush
command to the frontend. Some devices like the tm6000 seem to require
this to properly flush the I2C buffers.

The current code in tm6000 executes the flush command once after each
I2C transfer, which slows down the firmware loading especially when
loading large BASE type images.

Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/common/tuners/tuner-xc2028.c
drivers/media/common/tuners/tuner-xc2028.h

index 16fba6b59616034382bbf09018795fb29cc4eba1..b6b2868cb3f00bdfd4cfe9574255d8338ab0362e 100644 (file)
@@ -614,6 +614,13 @@ static int load_firmware(struct dvb_frontend *fe, unsigned int type,
                        p += len;
                        size -= len;
                }
+
+               /* silently fail if the frontend doesn't support I2C flush */
+               rc = do_tuner_callback(fe, XC2028_I2C_FLUSH, 0);
+               if ((rc < 0) && (rc != -EINVAL)) {
+                       tuner_err("error executing flush: %d\n", rc);
+                       return rc;
+               }
        }
        return 0;
 }
index 9778c96a5006b03f88b5659c2b043c3024f9698f..9ebfb2d0ff149b70451dfc5a0ec3133c51fdee0e 100644 (file)
@@ -54,6 +54,7 @@ struct xc2028_config {
 /* xc2028 commands for callback */
 #define XC2028_TUNER_RESET     0
 #define XC2028_RESET_CLK       1
+#define XC2028_I2C_FLUSH       2
 
 #if defined(CONFIG_MEDIA_TUNER_XC2028) || (defined(CONFIG_MEDIA_TUNER_XC2028_MODULE) && defined(MODULE))
 extern struct dvb_frontend *xc2028_attach(struct dvb_frontend *fe,