perf ui progress: Make sure we always define step value
authorJiri Olsa <jolsa@kernel.org>
Fri, 8 Sep 2017 12:05:07 +0000 (14:05 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 12 Sep 2017 15:34:46 +0000 (12:34 -0300)
Unlikely, but we could have ui_progress__init being called with total <
16, which would set the next and step variables to 0. That would force
unnecessary ui_progress__ops->update calls because 'next' would never
raise.

Forcing the next and step values to be always > 0.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20170908120510.22515-2-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/progress.c

index a0f24c7115c59f891fa894739ef4da157a9e33cf..a9c15804b1f650059e044f9c6ff9a661350b8a5c 100644 (file)
@@ -25,7 +25,7 @@ void ui_progress__update(struct ui_progress *p, u64 adv)
 void ui_progress__init(struct ui_progress *p, u64 total, const char *title)
 {
        p->curr = 0;
-       p->next = p->step = total / 16;
+       p->next = p->step = total / 16 ?: 1;
        p->total = total;
        p->title = title;