perf hists: Rename hist_entry__add_pair arguments
authorJiri Olsa <jolsa@redhat.com>
Thu, 13 Dec 2012 13:09:00 +0000 (14:09 +0100)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 28 May 2013 13:24:02 +0000 (16:24 +0300)
The current logic is to attach pair to the leader hist_entry.

Arguments of hist_entry__add_pair function were placed the other way
round.. driving me crazy.

I.e. list_add_tail expects (new_node, head).

Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1355404152-16523-3-git-send-email-jolsa@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/sort.h

index 51f1b5a854e781924d4d3f23bd308a8a34d86189..45ac84c1e037595a9a0070142ef68a9f067aa422 100644 (file)
@@ -117,10 +117,10 @@ static inline struct hist_entry *hist_entry__next_pair(struct hist_entry *he)
        return NULL;
 }
 
-static inline void hist_entry__add_pair(struct hist_entry *he,
-                                       struct hist_entry *pair)
+static inline void hist_entry__add_pair(struct hist_entry *pair,
+                                       struct hist_entry *he)
 {
-       list_add_tail(&he->pairs.head, &pair->pairs.node);
+       list_add_tail(&pair->pairs.node, &he->pairs.head);
 }
 
 enum sort_mode {