sched/topology: Drop memset() from init_rootdomain()
authorViresh Kumar <viresh.kumar@linaro.org>
Thu, 13 Apr 2017 09:15:48 +0000 (14:45 +0530)
committerIngo Molnar <mingo@kernel.org>
Thu, 10 Aug 2017 10:18:13 +0000 (12:18 +0200)
There are only two callers of init_rootdomain(). One of them passes a
global to it and another one sends dynamically allocated root-domain.

There is no need to memset the root-domain in the first case as the
structure is already reset.

Update alloc_rootdomain() to allocate the memory with kzalloc() and
remove the memset() call from init_rootdomain().

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linaro-kernel@lists.linaro.org
Link: http://lkml.kernel.org/r/fc2f6cc90b098040970c85a97046512572d765bc.1492065513.git.viresh.kumar@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/topology.c

index 79895aec281eb5ad198fae3e5e8aed31849ed900..216fee014b32bf206c6e3ab767bbafc5c0c6a580 100644 (file)
@@ -261,8 +261,6 @@ void rq_attach_root(struct rq *rq, struct root_domain *rd)
 
 static int init_rootdomain(struct root_domain *rd)
 {
-       memset(rd, 0, sizeof(*rd));
-
        if (!zalloc_cpumask_var(&rd->span, GFP_KERNEL))
                goto out;
        if (!zalloc_cpumask_var(&rd->online, GFP_KERNEL))
@@ -311,7 +309,7 @@ static struct root_domain *alloc_rootdomain(void)
 {
        struct root_domain *rd;
 
-       rd = kmalloc(sizeof(*rd), GFP_KERNEL);
+       rd = kzalloc(sizeof(*rd), GFP_KERNEL);
        if (!rd)
                return NULL;