pinctrl: sprd: fix off by one bugs

info->groups[] has info->ngroups elements so these comparisons should be
>= instead of >.

Fixes: 41d32cfce1ae ("pinctrl: sprd: Add Spreadtrum pin control driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Baolin Wang <baolin.wang@spreadtrum.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c
index e52a01e1f662eaca77e6554a69b272d9aec8f078..63529911445c7815bd5b455db7d73fe03c328a77 100644 (file)
--- a/drivers/pinctrl/sprd/pinctrl-sprd.c
+++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
@@ -400,7 +400,7 @@ static int sprd_pmx_set_mux(struct pinctrl_dev *pctldev,
        unsigned long reg;
        unsigned int val = 0;
 
-       if (group_selector > info->ngroups)
+       if (group_selector >= info->ngroups)
                return -EINVAL;
 
        switch (func_selector) {
@@ -734,7 +734,7 @@ static int sprd_pinconf_group_get(struct pinctrl_dev *pctldev,
        struct sprd_pin_group *grp;
        unsigned int pin_id;
 
-       if (selector > info->ngroups)
+       if (selector >= info->ngroups)
                return -EINVAL;
 
        grp = &info->groups[selector];
@@ -753,7 +753,7 @@ static int sprd_pinconf_group_set(struct pinctrl_dev *pctldev,
        struct sprd_pin_group *grp;
        int ret, i;
 
-       if (selector > info->ngroups)
+       if (selector >= info->ngroups)
                return -EINVAL;
 
        grp = &info->groups[selector];
@@ -813,7 +813,7 @@ static void sprd_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
        const char *name;
        int i, ret;
 
-       if (selector > info->ngroups)
+       if (selector >= info->ngroups)
                return;
 
        grp = &info->groups[selector];