prism54: call BUG_ON() earlier
authorDan Carpenter <error27@gmail.com>
Sat, 10 Jul 2010 08:53:38 +0000 (10:53 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 12 Jul 2010 20:05:32 +0000 (16:05 -0400)
This test is off by one because strlen() doesn't include the NULL
terminator.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/prism54/isl_ioctl.c

index 236e37526d07faaf65213490c9af7f79cabbed61..2e656bb7e14e9b3d48687ea273257e77ac54b222 100644 (file)
@@ -2067,7 +2067,7 @@ send_simple_event(islpci_private *priv, const char *str)
        memptr = kmalloc(IW_CUSTOM_MAX, GFP_KERNEL);
        if (!memptr)
                return;
-       BUG_ON(n > IW_CUSTOM_MAX);
+       BUG_ON(n >= IW_CUSTOM_MAX);
        wrqu.data.pointer = memptr;
        wrqu.data.length = n;
        strcpy(memptr, str);