ocfs2: Remove ocfs2_sync_inode()
authorJan Kara <jack@suse.cz>
Thu, 5 Aug 2010 18:32:46 +0000 (20:32 +0200)
committerJoel Becker <joel.becker@oracle.com>
Fri, 10 Sep 2010 15:39:44 +0000 (08:39 -0700)
ocfs2_sync_inode() is used only from ocfs2_sync_file(). But all data has
already been written before calling ocfs2_sync_file() and ocfs2 doesn't use
inode's private_list for tracking metadata buffers thus sync_mapping_buffers()
is superfluous as well.

Signed-off-by: Jan Kara <jack@suse.cz>
Acked-by: Mark Fasheh <mfasheh@suse.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
fs/ocfs2/file.c

index 4f9133f6368ea9cd1ab631b09bb18601763b9242..b03f6601fd71b523b39f333d26b16b99bb7076c9 100644 (file)
 
 #include "buffer_head_io.h"
 
-static int ocfs2_sync_inode(struct inode *inode)
-{
-       filemap_fdatawrite(inode->i_mapping);
-       return sync_mapping_buffers(inode->i_mapping);
-}
-
 static int ocfs2_init_file_private(struct inode *inode, struct file *file)
 {
        struct ocfs2_file_private *fp;
@@ -187,10 +181,6 @@ static int ocfs2_sync_file(struct file *file, int datasync)
        mlog_entry("(0x%p, 0x%p, %d, '%.*s')\n", file, dentry, datasync,
                   dentry->d_name.len, dentry->d_name.name);
 
-       err = ocfs2_sync_inode(dentry->d_inode);
-       if (err)
-               goto bail;
-
        if (datasync && !(inode->i_state & I_DIRTY_DATASYNC)) {
                /*
                 * We still have to flush drive's caches to get data to the