drm/exynos: exynos_hdmi: Pass correct pointer to free_irq()
authorLars-Peter Clausen <lars@metafoo.de>
Mon, 20 May 2013 17:32:06 +0000 (19:32 +0200)
committerInki Dae <inki.dae@samsung.com>
Wed, 22 May 2013 02:45:51 +0000 (11:45 +0900)
free_irq() expects the same pointer that was passed to request_threaded_irq(),
otherwise the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_threaded_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
drivers/gpu/drm/exynos/exynos_hdmi.c

index bbfc3840080cf03b718e76fb0aa9f3119ec4ba24..7e99853f1e18460a2334ae91cc0234f3464d7737 100644 (file)
@@ -2082,7 +2082,7 @@ static int hdmi_remove(struct platform_device *pdev)
 
        pm_runtime_disable(dev);
 
-       free_irq(hdata->irq, hdata);
+       free_irq(hdata->irq, ctx);
 
 
        /* hdmiphy i2c driver */