arm64: hw-breakpoint: Remove superfluous SMP function call
authorAnna-Maria Gleixner <anna-maria@linutronix.de>
Wed, 6 Apr 2016 08:42:49 +0000 (10:42 +0200)
committerWill Deacon <will.deacon@arm.com>
Thu, 14 Apr 2016 17:13:03 +0000 (18:13 +0100)
Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to
hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and
CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this SMP
function calls are no longer required.

Replace smp_call_function_single() with a direct call of
hw_breakpoint_reset(). To keep the calling convention, interrupts are
explicitly disabled around the call.

Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm64/kernel/hw_breakpoint.c

index b45c95d34b8323e74992e0a4a56e6da0e1257c60..11dc50ac643a5bcf580e85bbd7586d70f6c3c85b 100644 (file)
@@ -886,9 +886,11 @@ static int hw_breakpoint_reset_notify(struct notifier_block *self,
                                                unsigned long action,
                                                void *hcpu)
 {
-       int cpu = (long)hcpu;
-       if ((action & ~CPU_TASKS_FROZEN) == CPU_ONLINE)
-               smp_call_function_single(cpu, hw_breakpoint_reset, NULL, 1);
+       if ((action & ~CPU_TASKS_FROZEN) == CPU_ONLINE) {
+               local_irq_disable();
+               hw_breakpoint_reset(NULL);
+               local_irq_enable();
+       }
        return NOTIFY_OK;
 }