drivers/macintosh: Delete an unnecessary check before the function call "of_node_put"
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 4 Feb 2015 20:32:27 +0000 (21:32 +0100)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Wed, 25 Mar 2015 05:53:27 +0000 (16:53 +1100)
The of_node_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
drivers/macintosh/smu.c

index 10ae69bcbbd2d47a44f8e258cb3659e9d128bec1..d531f804455d254ec90aa0f2e4573f21aef57ba8 100644 (file)
@@ -557,8 +557,7 @@ int __init smu_init (void)
        return 0;
 
 fail_msg_node:
-       if (smu->msg_node)
-               of_node_put(smu->msg_node);
+       of_node_put(smu->msg_node);
 fail_db_node:
        of_node_put(smu->db_node);
 fail_bootmem: