brcmfmac: Create netdev before returning from add_virtual_intf.

Currently netdev gets created possibly after returning from
add_virtual_intf. This is because add_if is handled asynch. This
is wrong and netdev should be up before returning.

Reviewed-by: Arend Van Spriel <arend@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Piotr Haber <phaber@broadcom.com>
Signed-off-by: Hante Meuleman <meuleman@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

diff --git a/drivers/net/wireless/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/brcm80211/brcmfmac/p2p.c
index fd090745b82f0b8e60fd08f8e5edb81f2d4131fb..84d6acd99353200c234d1b076ddebde7fc06519c 100644 (file)
--- a/drivers/net/wireless/brcm80211/brcmfmac/p2p.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/p2p.c
@@ -1591,7 +1591,11 @@ struct wireless_dev *brcmf_p2p_add_vif(struct wiphy *wiphy, const char *name,
        }
 
        strncpy(ifp->ndev->name, name, sizeof(ifp->ndev->name) - 1);
-       brcmf_cfg80211_vif_complete(cfg);
+       err = brcmf_net_attach(ifp, true);
+       if (err) {
+               brcmf_err("Registering netdevice failed\n");
+               goto fail;
+       }
        cfg->p2p.bss_idx[P2PAPI_BSSCFG_CONNECTION].vif = vif;
        /* Disable firmware roaming for P2P interface  */
        brcmf_fil_iovar_int_set(ifp, "roam_off", 1);

diff --git a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
index 6cdb578fc37b0598924f9b1f316d98b4f234a1fe..b5cc15463576bce55cdf19de7bebef3ddad3a264 100644 (file)
--- a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
@@ -4665,10 +4665,7 @@ static s32 brcmf_notify_vif_event(struct brcmf_if *ifp,
                SET_NETDEV_DEV(ifp->ndev, wiphy_dev(cfg->wiphy));
                mutex_unlock(&event->vif_event_lock);
                wake_up(&event->vif_wq);
-
-               /* waiting process need to set the netdev name */
-               wait_for_completion(&event->vif_complete);
-               return brcmf_net_attach(ifp, true);
+               return 0;
 
        case BRCMF_E_IF_DEL:
                ifp->vif = NULL;
@@ -4800,7 +4797,6 @@ static void wl_deinit_priv(struct brcmf_cfg80211_info *cfg)
 static void init_vif_event(struct brcmf_cfg80211_vif_event *event)
 {
        init_waitqueue_head(&event->vif_wq);
-       init_completion(&event->vif_complete);
        mutex_init(&event->vif_event_lock);
 }
 
@@ -5154,7 +5150,3 @@ int brcmf_cfg80211_wait_vif_event_timeout(struct brcmf_cfg80211_info *cfg,
                                  vif_event_equals(event, action), timeout);
 }
 
-void brcmf_cfg80211_vif_complete(struct brcmf_cfg80211_info *cfg)
-{
-       complete(&cfg->vif_event.vif_complete);
-}

diff --git a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.h b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.h
index b886f22a4acbe4fd8b10bb0e549e9324d14c92af..8b5d4989906c54e9f95df3096e9567f1738fd2c3 100644 (file)
--- a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.h
+++ b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.h
@@ -337,7 +337,6 @@ struct brcmf_pno_scanresults_le {
 struct brcmf_cfg80211_vif_event {
        wait_queue_head_t vif_wq;
        struct mutex vif_event_lock;
-       struct completion vif_complete;
        u8 action;
        struct brcmf_cfg80211_vif *vif;
 };
@@ -493,7 +492,6 @@ void brcmf_cfg80211_arm_vif_event(struct brcmf_cfg80211_info *cfg,
 bool brcmf_cfg80211_vif_event_armed(struct brcmf_cfg80211_info *cfg);
 int brcmf_cfg80211_wait_vif_event_timeout(struct brcmf_cfg80211_info *cfg,
                                          u8 action, ulong timeout);
-void brcmf_cfg80211_vif_complete(struct brcmf_cfg80211_info *info);
 s32 brcmf_notify_escan_complete(struct brcmf_cfg80211_info *cfg,
                                struct net_device *ndev,
                                bool aborted, bool fw_abort);