btrfs: Error handle for get_ref_objectid_v0() in relocate_block_group()
authorZhaolei <zhaolei@cn.fujitsu.com>
Wed, 5 Aug 2015 10:00:02 +0000 (18:00 +0800)
committerChris Mason <clm@fb.com>
Sun, 9 Aug 2015 14:07:13 +0000 (07:07 -0700)
We need error checking code for get_ref_objectid_v0() in
relocate_block_group(), to avoid unpredictable result, especially
for accessing uninitialized value(when function failed) after
this line.

Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: Chris Mason <clm@fb.com>
fs/btrfs/relocation.c

index 52fe55ad11d66e5b8ad2922c8f26d08e2dc23055..1659c94f179c389a598e5b2fcf81ddb8eb9d5de7 100644 (file)
@@ -3976,6 +3976,10 @@ restart:
                               sizeof(struct btrfs_extent_item_v0));
                        ret = get_ref_objectid_v0(rc, path, &key, &ref_owner,
                                                  &path_change);
+                       if (ret < 0) {
+                               err = ret;
+                               break;
+                       }
                        if (ref_owner < BTRFS_FIRST_FREE_OBJECTID)
                                flags = BTRFS_EXTENT_FLAG_TREE_BLOCK;
                        else