tick: Cleanup NOHZ per cpu data on cpu down
authorThomas Gleixner <tglx@linutronix.de>
Fri, 3 May 2013 13:02:50 +0000 (15:02 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Sun, 12 May 2013 10:20:09 +0000 (12:20 +0200)
Prarit reported a crash on CPU offline/online. The reason is that on
CPU down the NOHZ related per cpu data of the dead cpu is not cleaned
up. If at cpu online an interrupt happens before the per cpu tick
device is registered the irq_enter() check potentially sees stale data
and dereferences a NULL pointer.

Cleanup the data after the cpu is dead.

Reported-by: Prarit Bhargava <prarit@redhat.com>
Cc: stable@vger.kernel.org
Cc: Mike Galbraith <bitbucket@online.de>
Link: http://lkml.kernel.org/r/alpine.LFD.2.02.1305031451561.2886@ionos
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
kernel/time/tick-sched.c

index 225f8bf19095a6f4e4abb5b2bc2458fb5b6baf1b..0eed1db2d79240d7aee144dc52c321be73a2a2f7 100644 (file)
@@ -904,7 +904,7 @@ void tick_cancel_sched_timer(int cpu)
                hrtimer_cancel(&ts->sched_timer);
 # endif
 
-       ts->nohz_mode = NOHZ_MODE_INACTIVE;
+       memset(ts, 0, sizeof(*ts));
 }
 #endif