ASoC: max98090: Fix missing free_irq
authorJarkko Nikula <jarkko.nikula@linux.intel.com>
Thu, 19 Jun 2014 06:32:05 +0000 (09:32 +0300)
committerMark Brown <broonie@linaro.org>
Thu, 19 Jun 2014 09:57:00 +0000 (10:57 +0100)
max98090.c doesn't free the threaded interrupt it requests. This causes
an oops when doing "cat /proc/interrupts" after snd-soc-max98090.ko is
unloaded.

Fix this by requesting the interrupt by using devm_request_threaded_irq().

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: Stable <stable@vger.kernel.org> # 3.10+
Signed-off-by: Mark Brown <broonie@linaro.org>
sound/soc/codecs/max98090.c

index f5fccc7a8e89b59b42911fb5684d8ab31b775b52..d97f1ce7ff7de78598e7e98cd9ab18e23bd7d65e 100644 (file)
@@ -2284,7 +2284,7 @@ static int max98090_probe(struct snd_soc_codec *codec)
        /* Register for interrupts */
        dev_dbg(codec->dev, "irq = %d\n", max98090->irq);
 
-       ret = request_threaded_irq(max98090->irq, NULL,
+       ret = devm_request_threaded_irq(codec->dev, max98090->irq, NULL,
                max98090_interrupt, IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
                "max98090_interrupt", codec);
        if (ret < 0) {