staging/rtl8821ae: fix sparse address space warning
authorAnders Darander <anders.darander@gmail.com>
Wed, 23 Apr 2014 13:09:50 +0000 (15:09 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2014 23:02:01 +0000 (16:02 -0700)
Change the definition of pci_mem_start|end from correct from pci_io(un)map's
point of view.

Signed-off-by: Anders Darander <anders.darander@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8821ae/pci.c
drivers/staging/rtl8821ae/wifi.h

index a562aa60d5955bf3a2d15c4383379e85e5fff1d9..94f72832a83881d0a9c695e58dc2ae0684206ba2 100644 (file)
@@ -2313,16 +2313,16 @@ int __devinit rtl_pci_probe(struct pci_dev *pdev,
 
        /*shared mem start */
        rtlpriv->io.pci_mem_start =
-                       (unsigned long)pci_iomap(pdev,
+                       pci_iomap(pdev,
                        rtlpriv->cfg->bar_id, pmem_len);
-       if (rtlpriv->io.pci_mem_start == 0) {
+       if (rtlpriv->io.pci_mem_start == NULL) {
                RT_ASSERT(false, ("Can't map PCI mem\n"));
                goto fail2;
        }
 
        RT_TRACE(COMP_INIT, DBG_DMESG,
                 ("mem mapped space: start: 0x%08lx len:%08lx "
-                 "flags:%08lx, after map:0x%08lx\n",
+                 "flags:%08lx, after map:0x%p\n",
                  pmem_start, pmem_len, pmem_flags,
                  rtlpriv->io.pci_mem_start));
 
@@ -2415,8 +2415,8 @@ fail3:
        rtl_deinit_core(hw);
        ieee80211_free_hw(hw);
 
-       if (rtlpriv->io.pci_mem_start != 0)
-               pci_iounmap(pdev, (void *)rtlpriv->io.pci_mem_start);
+       if (rtlpriv->io.pci_mem_start != NULL)
+               pci_iounmap(pdev, rtlpriv->io.pci_mem_start);
 
 fail2:
        pci_release_regions(pdev);
@@ -2478,8 +2478,8 @@ void rtl_pci_disconnect(struct pci_dev *pdev)
                pci_disable_msi(rtlpci->pdev);
 
        list_del(&rtlpriv->list);
-       if (rtlpriv->io.pci_mem_start != 0) {
-               pci_iounmap(pdev, (void *)rtlpriv->io.pci_mem_start);
+       if (rtlpriv->io.pci_mem_start != NULL) {
+               pci_iounmap(pdev, rtlpriv->io.pci_mem_start);
                pci_release_regions(pdev);
        }
 
index 17a9d9f8781d53b95688cff21a654e95183d91e1..e8250dad613bd75668983798082a7438e11f7d71 100644 (file)
@@ -1086,8 +1086,8 @@ struct rtl_io {
        struct device *dev;
 
        /*PCI MEM map */
-       unsigned long pci_mem_end;      /*shared mem end        */
-       unsigned long pci_mem_start;    /*shared mem start */
+       void __iomem *pci_mem_end;      /*shared mem end        */
+       void __iomem *pci_mem_start;    /*shared mem start */
 
        /*PCI IO map */
        unsigned long pci_base_addr;    /*device I/O address */