projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: fb76dd1)
Input: tps6507x-ts - remove unneeded NULL test
authorJiri Slaby <jslaby@suse.cz>
Tue, 22 Jun 2010 18:25:03 +0000 (11:25 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 23 Jun 2010 16:44:51 +0000 (09:44 -0700)
Stanse found that tsc is dereferenced earlier than checked for being
NULL in tps6507x_ts_remove. Remove the test because there is no way
for tsc to be NULL there.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
drivers/input/touchscreen/tps6507x-ts.c patch | blob | blame | history

diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c
index 5b70a1419b4d6da36fe5486b5b732d647691bdff..a644d18c04dce09862663004217864698948fef0 100644 (file)
--- a/drivers/input/touchscreen/tps6507x-ts.c
+++ b/drivers/input/touchscreen/tps6507x-ts.c
@@ -355,9 +355,6 @@ static int __devexit tps6507x_ts_remove(struct platform_device *pdev)
        struct tps6507x_ts *tsc = tps6507x_dev->ts;
        struct input_dev *input_dev = tsc->input_dev;
 
-       if (!tsc)
-               return 0;
-
        cancel_delayed_work_sync(&tsc->work);
        destroy_workqueue(tsc->wq);