netfilter: Validate the sequence number of dataless ACK packets as well
authorJozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Fri, 31 Aug 2012 09:55:54 +0000 (09:55 +0000)
committerPablo Neira Ayuso <pablo@netfilter.org>
Sun, 9 Sep 2012 20:13:49 +0000 (22:13 +0200)
We spare nothing by not validating the sequence number of dataless
ACK packets and enabling it makes harder off-path attacks.

See: "Reflection scan: an Off-Path Attack on TCP" by Jan Wrobel,
http://arxiv.org/abs/1201.2074

Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_conntrack_proto_tcp.c

index aba98f942979a01c8266fbd5eb967bb1ee01e705..e046b3756aab755080d3edced132c459b7c8d4c4 100644 (file)
@@ -630,15 +630,9 @@ static bool tcp_in_window(const struct nf_conn *ct,
                ack = sack = receiver->td_end;
        }
 
-       if (seq == end
-           && (!tcph->rst
-               || (seq == 0 && state->state == TCP_CONNTRACK_SYN_SENT)))
+       if (tcph->rst && seq == 0 && state->state == TCP_CONNTRACK_SYN_SENT)
                /*
-                * Packets contains no data: we assume it is valid
-                * and check the ack value only.
-                * However RST segments are always validated by their
-                * SEQ number, except when seq == 0 (reset sent answering
-                * SYN.
+                * RST sent answering SYN.
                 */
                seq = end = sender->td_end;