ocfs2: remove bogus test from ocfs2_read_locked_inode()
authorJan Kara <jack@suse.cz>
Wed, 10 Dec 2014 23:41:42 +0000 (15:41 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 11 Dec 2014 01:41:03 +0000 (17:41 -0800)
'args' are always set for ocfs2_read_locked_inode() and brelse() checks
whether bh is NULL.  So the test (args && bh) is unnecessary (plus the
args part is really confusing anyway).  Remove it.

Coverity id: 1128856.

Signed-off-by: Jan Kara <jack@suse.cz>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/ocfs2/inode.c

index 437de7f768c6e5ae6a75e1e07b8e522ebdd0a494..c8b25de9efbbf93217480059fdca6f44e7513d56 100644 (file)
@@ -540,8 +540,7 @@ bail:
        if (status < 0)
                make_bad_inode(inode);
 
-       if (args && bh)
-               brelse(bh);
+       brelse(bh);
 
        return status;
 }