projects
/
GitHub
/
LineageOS
/
android_kernel_motorola_exynos9610.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
71e15ed
)
ALSA: pcm: fix divide error in snd_pcm_lib_ioctl
author
Zubin Mithra
<zsm@chromium.org>
Fri, 27 Aug 2021 15:37:35 +0000
(08:37 -0700)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 09:45:15 +0000
(11:45 +0200)
commit
f3eef46f0518a2b32ca1244015820c35a22cfe4a
upstream.
Syzkaller reported a divide error in snd_pcm_lib_ioctl. fifo_size
is of type snd_pcm_uframes_t(unsigned long). If frame_size
is 0x100000000, the error occurs.
Fixes:
a9960e6a293e
("ALSA: pcm: fix fifo_size frame calculation")
Signed-off-by: Zubin Mithra <zsm@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Cc: <stable@vger.kernel.org>
Link:
https://lore.kernel.org/r/20210827153735.789452-1-zsm@chromium.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/core/pcm_lib.c
patch
|
blob
|
blame
|
history
diff --git
a/sound/core/pcm_lib.c
b/sound/core/pcm_lib.c
index c412f2a909c9ca15ca39157066781bda14265592..82a7387ba9d2494ee3afcc3ef18ae5561874a056 100644
(file)
--- a/
sound/core/pcm_lib.c
+++ b/
sound/core/pcm_lib.c
@@
-1757,7
+1757,7
@@
static int snd_pcm_lib_ioctl_fifo_size(struct snd_pcm_substream *substream,
channels = params_channels(params);
frame_size = snd_pcm_format_size(format, channels);
if (frame_size > 0)
- params->fifo_size /=
(unsigned)
frame_size;
+ params->fifo_size /= frame_size;
}
return 0;
}