can: peak_pci: fix error return code
authorPeter Senna Tschudin <peter.senna@gmail.com>
Wed, 3 Oct 2012 16:17:54 +0000 (18:17 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 4 Oct 2012 17:24:39 +0000 (19:24 +0200)
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/sja1000/peak_pci.c

index f0a12962f7b68df338dc3a627317e77975741382..f5b82aeb2540af2646f38dce966096ac221e3eaf 100644 (file)
@@ -583,12 +583,14 @@ static int __devinit peak_pci_probe(struct pci_dev *pdev,
        cfg_base = pci_iomap(pdev, 0, PEAK_PCI_CFG_SIZE);
        if (!cfg_base) {
                dev_err(&pdev->dev, "failed to map PCI resource #0\n");
+               err = -ENOMEM;
                goto failure_release_regions;
        }
 
        reg_base = pci_iomap(pdev, 1, PEAK_PCI_CHAN_SIZE * channels);
        if (!reg_base) {
                dev_err(&pdev->dev, "failed to map PCI resource #1\n");
+               err = -ENOMEM;
                goto failure_unmap_cfg_base;
        }