clk: rockchip: don't return NULL when failing to register ddrclk branch
authorShawn Lin <shawn.lin@rock-chips.com>
Wed, 12 Oct 2016 12:31:41 +0000 (20:31 +0800)
committerHeiko Stuebner <heiko@sntech.de>
Sun, 16 Oct 2016 00:39:58 +0000 (02:39 +0200)
rockchip_clk_register_ddrclk should not return NULL when failing
to call clk_register, otherwise rockchip_clk_register_branches
prints "unknown clock type". The actual case is that it's a known
clock type but we fail to register it, which may makes user confuse
the reason of failure. And the pr_err here is pointless as
rockchip_clk_register_branches will also print the similar message.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
drivers/clk/rockchip/clk-ddr.c

index 8feba93672c5e4248a98c7116887995756bc77f5..e8075359366b0d9ef9cf84611d6c36b19fc22c4a 100644 (file)
@@ -144,11 +144,8 @@ struct clk *rockchip_clk_register_ddrclk(const char *name, int flags,
        ddrclk->ddr_flag = ddr_flag;
 
        clk = clk_register(NULL, &ddrclk->hw);
-       if (IS_ERR(clk)) {
-               pr_err("%s: could not register ddrclk %s\n", __func__,  name);
+       if (IS_ERR(clk))
                kfree(ddrclk);
-               return NULL;
-       }
 
        return clk;
 }