MIPS,bpf: fix missing break in switch statement
authorColin Ian King <colin.king@canonical.com>
Tue, 22 Aug 2017 22:46:06 +0000 (23:46 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 22 Aug 2017 23:18:00 +0000 (16:18 -0700)
There is a missing break causing a fall-through and setting
ctx.use_bbit_insns to the wrong value. Fix this by adding the
missing break.

Detected with cppcheck:
"Variable 'ctx.use_bbit_insns' is reassigned a value before the old
one has been used. 'break;' missing?"

Fixes: 8d8d18c3283f ("MIPS,bpf: Fix using smp_processor_id() in preemptible splat.")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: David Daney <david.daney@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
arch/mips/net/ebpf_jit.c

index 44ddc12cbb0e07b380d807c522f5ef912d6543ce..7646891c4e9b18077d59ac28bfe2ffe5b82d0d37 100644 (file)
@@ -1892,6 +1892,7 @@ struct bpf_prog *bpf_int_jit_compile(struct bpf_prog *prog)
        case CPU_CAVIUM_OCTEON2:
        case CPU_CAVIUM_OCTEON3:
                ctx.use_bbit_insns = 1;
+               break;
        default:
                ctx.use_bbit_insns = 0;
        }