projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 0b49573)
[ARM] S3C: Fix gpio-config off-by-one bug
authorMarek Szyprowski <m.szyprowski@samsung.com>
Thu, 18 Jun 2009 11:30:16 +0000 (13:30 +0200)
committerBen Dooks <ben-linux@fluff.org>
Mon, 22 Jun 2009 13:12:39 +0000 (14:12 +0100)
Fix gpio-config off-by-one bug. Without this patch, touching GPA0 pin on
S3C64XX platform causes kernel oops.

Reviewed-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
arch/arm/plat-s3c/gpio-config.c patch | blob | blame | history

diff --git a/arch/arm/plat-s3c/gpio-config.c b/arch/arm/plat-s3c/gpio-config.c
index 08044dec9731ec3890c76d9ac09e77c7d0091223..456969b6fa0d6670a989d1d28d85b214d9d9bf1d 100644 (file)
--- a/arch/arm/plat-s3c/gpio-config.c
+++ b/arch/arm/plat-s3c/gpio-config.c
@@ -119,7 +119,7 @@ int s3c_gpio_setcfg_s3c64xx_4bit(struct s3c_gpio_chip *chip,
        unsigned int shift = (off & 7) * 4;
        u32 con;
 
-       if (off < 8 && chip->chip.ngpio >= 8)
+       if (off < 8 && chip->chip.ngpio > 8)
                reg -= 4;
 
        if (s3c_gpio_is_cfg_special(cfg)) {