fscrypt: don't clear flags on crypto transform
authorEric Biggers <ebiggers@google.com>
Mon, 30 Apr 2018 22:51:40 +0000 (15:51 -0700)
committerJaegeuk Kim <jaegeuk@kernel.org>
Thu, 28 Jun 2018 16:37:40 +0000 (09:37 -0700)
fscrypt is clearing the flags on the crypto_skcipher it allocates for
each inode.  But, this is unnecessary and may cause problems in the
future because it will even clear flags that are meant to be internal to
the crypto API, e.g. CRYPTO_TFM_NEED_KEY.

Remove the unnecessary flag clearing.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/crypto/keyinfo.c

index d09df8f751df047d2c5d5b826e61cf2f295c6c50..0f6a65c6483b3d3ad3b3cb06169a89469b6208d3 100644 (file)
@@ -325,7 +325,6 @@ int fscrypt_get_encryption_info(struct inode *inode)
                goto out;
        }
        crypt_info->ci_ctfm = ctfm;
-       crypto_skcipher_clear_flags(ctfm, ~0);
        crypto_skcipher_set_flags(ctfm, CRYPTO_TFM_REQ_WEAK_KEY);
        /*
         * if the provided key is longer than keysize, we use the first