drm/sun4i: Ignore the generic connectors for components
authorMaxime Ripard <maxime.ripard@free-electrons.com>
Sat, 27 May 2017 16:09:32 +0000 (18:09 +0200)
committerMaxime Ripard <maxime.ripard@free-electrons.com>
Thu, 1 Jun 2017 07:49:59 +0000 (09:49 +0200)
The generic connectors such as hdmi-connector doesn't have any driver in,
so if they are added to the component list, we will be waiting forever for
a non-existing driver to probe.

Add a list of the connectors we want to ignore when building our component
list.

Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
drivers/gpu/drm/sun4i/sun4i_drv.c

index 1dd1948025d2d1a3418d1cd849882a04a6dd0d3b..cfc0b2fcb0a694e2551434f49cb3c4c0874f3fb6 100644 (file)
@@ -166,6 +166,11 @@ static const struct component_master_ops sun4i_drv_master_ops = {
        .unbind = sun4i_drv_unbind,
 };
 
+static bool sun4i_drv_node_is_connector(struct device_node *node)
+{
+       return of_device_is_compatible(node, "hdmi-connector");
+}
+
 static bool sun4i_drv_node_is_frontend(struct device_node *node)
 {
        return of_device_is_compatible(node, "allwinner,sun5i-a13-display-frontend") ||
@@ -207,6 +212,13 @@ static int sun4i_drv_add_endpoints(struct device *dev,
            !of_device_is_available(node))
                return 0;
 
+       /*
+        * The connectors will be the last nodes in our pipeline, we
+        * can just bail out.
+        */
+       if (sun4i_drv_node_is_connector(node))
+               return 0;
+
        if (!sun4i_drv_node_is_frontend(node)) {
                /* Add current component */
                DRM_DEBUG_DRIVER("Adding component %s\n",