arm64/debug: Remove superfluous SMP function call
authorAnna-Maria Gleixner <anna-maria@linutronix.de>
Wed, 6 Apr 2016 08:42:28 +0000 (10:42 +0200)
committerWill Deacon <will.deacon@arm.com>
Thu, 14 Apr 2016 17:13:03 +0000 (18:13 +0100)
Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to
hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and
CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this SMP
function calls are no longer required.

Replace smp_call_function_single() with a direct call to
clear_os_lock(). The function writes the OSLAR register to clear OS
locking. This does not require to be called with interrupts disabled,
therefore the smp_call_function_single() calling convention is not
preserved.

Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm64/kernel/debug-monitors.c

index c45f2968bc8ce251313badc343c60ab9cc7a88d9..4fbf3c54275c33c832470155afa29c52074887c2 100644 (file)
@@ -135,9 +135,8 @@ static void clear_os_lock(void *unused)
 static int os_lock_notify(struct notifier_block *self,
                                    unsigned long action, void *data)
 {
-       int cpu = (unsigned long)data;
        if ((action & ~CPU_TASKS_FROZEN) == CPU_ONLINE)
-               smp_call_function_single(cpu, clear_os_lock, NULL, 1);
+               clear_os_lock(NULL);
        return NOTIFY_OK;
 }