staging: rt5208: Fix a sleep-in-atomic bug in xd_copy_page

The driver may sleep under a spin lock, and the function call path is:
rtsx_exclusive_enter_ss (acquire the lock by spin_lock)
  rtsx_enter_ss
    rtsx_power_off_card
      xd_cleanup_work
        xd_delay_write
          xd_finish_write
            xd_copy_page
              wait_timeout
                schedule_timeout --> may sleep

To fix it, "wait_timeout" is replaced with mdelay in xd_copy_page.

Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index 85aba05acbc1ffcff497b81e2a02b177d3eb0a26..74d36f9a4c1d5cb1cdc708bc43b5630b102fe098 100644 (file)
--- a/drivers/staging/rts5208/xd.c
+++ b/drivers/staging/rts5208/xd.c
@@ -1268,7 +1268,7 @@ static int xd_copy_page(struct rtsx_chip *chip, u32 old_blk, u32 new_blk,
                        reg = 0;
                        rtsx_read_register(chip, XD_CTL, &reg);
                        if (reg & (XD_ECC1_ERROR | XD_ECC2_ERROR)) {
-                               wait_timeout(100);
+                               mdelay(100);
 
                                if (detect_card_cd(chip,
                                                   XD_CARD) != STATUS_SUCCESS) {