net/ax25: Use available error codes
authorJulia Lawall <julia@diku.dk>
Mon, 16 Aug 2010 06:28:19 +0000 (06:28 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 18 Aug 2010 21:26:31 +0000 (14:26 -0700)
Error codes are stored in err, but the return value is always 0.  Return
err instead.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
local idexpression x;
constant C;
@@

if (...) { ...
  x = -C
  ... when != x
(
  return <+...x...+>;
|
  return NULL;
|
  return;
|
* return ...;
)
}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ax25/af_ax25.c

index cfdfd7e2a1726b1399633bdcb6625a6a5731a310..26eaebf4aaa9b11c3b9d8820b835ae07c50219e2 100644 (file)
@@ -1103,7 +1103,7 @@ done:
 out:
        release_sock(sk);
 
-       return 0;
+       return err;
 }
 
 /*