rbd: Use min_t() to fix comparison of distinct pointer types warning
authorGeert Uytterhoeven <geert@linux-m68k.org>
Tue, 14 May 2013 01:35:37 +0000 (20:35 -0500)
committerSage Weil <sage@inktank.com>
Mon, 1 Jul 2013 16:52:01 +0000 (09:52 -0700)
drivers/block/rbd.c: In function ‘zero_pages’:
drivers/block/rbd.c:1102: warning: comparison of distinct pointer types lacks a cast

Remove the hackish casts and use min_t() to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Alex Elder <elder@inktank.com>
drivers/block/rbd.c

index aff789d6fccd35b7f0a0c3314e5c04951c6c774c..b4f00e22743dea6622c64a0501367e8af723e126 100644 (file)
@@ -1153,8 +1153,8 @@ static void zero_pages(struct page **pages, u64 offset, u64 end)
                unsigned long flags;
                void *kaddr;
 
-               page_offset = (size_t)(offset & ~PAGE_MASK);
-               length = min(PAGE_SIZE - page_offset, (size_t)(end - offset));
+               page_offset = offset & ~PAGE_MASK;
+               length = min_t(size_t, PAGE_SIZE - page_offset, end - offset);
                local_irq_save(flags);
                kaddr = kmap_atomic(*page);
                memset(kaddr + page_offset, 0, length);