drm/radeon/dpm/atom: restructure logic to work around a compiler bug
authorAndre Heider <a.heider@gmail.com>
Wed, 17 Jul 2013 18:02:23 +0000 (14:02 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 17 Jul 2013 18:52:49 +0000 (14:52 -0400)
It seems gcc 4.8.1 generates bogus code for the old logic causing
part of the function to get skipped.

Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=66932
https://bugs.freedesktop.org/show_bug.cgi?id=66972
https://bugs.freedesktop.org/show_bug.cgi?id=66945

Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/radeon_atombios.c

index a2e324188bc96195487072564d1827e1bf29ce5c..2606ec680ae356da79590d57be24ebab3feca5cf 100644 (file)
@@ -3703,8 +3703,9 @@ int radeon_atom_init_mc_reg_table(struct radeon_device *rdev,
                                                           sizeof(ATOM_INIT_REG_INDEX_FORMAT)) - 1;
                                        if (num_entries > VBIOS_MC_REGISTER_ARRAY_SIZE)
                                                return -EINVAL;
-                                       while (!(reg_block->asRegIndexBuf[i].ucPreRegDataLength & ACCESS_PLACEHOLDER) &&
-                                             (i < num_entries)) {
+                                       while (i < num_entries) {
+                                               if (reg_block->asRegIndexBuf[i].ucPreRegDataLength & ACCESS_PLACEHOLDER)
+                                                       break;
                                                reg_table->mc_reg_address[i].s1 =
                                                        (u16)(le16_to_cpu(reg_block->asRegIndexBuf[i].usRegIndex));
                                                reg_table->mc_reg_address[i].pre_reg_data =