drm/i915/bdw: Add missing delay during L3 SQC credit programming
authorImre Deak <imre.deak@intel.com>
Tue, 3 May 2016 12:54:19 +0000 (15:54 +0300)
committerImre Deak <imre.deak@intel.com>
Tue, 3 May 2016 13:49:09 +0000 (16:49 +0300)
BSpec requires us to wait ~100 clocks before re-enabling clock gating,
so make sure we do this.

CC: stable@vger.kernel.org
CC: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1462280061-1457-2-git-send-email-imre.deak@intel.com
drivers/gpu/drm/i915/intel_pm.c

index 2422ac38ce5d6ea46e19bf1081109d187d90739c..227cd2d395a9ff68ed6b3b034cb7c7b18206559b 100644 (file)
@@ -6738,6 +6738,12 @@ static void broadwell_init_clock_gating(struct drm_device *dev)
        misccpctl = I915_READ(GEN7_MISCCPCTL);
        I915_WRITE(GEN7_MISCCPCTL, misccpctl & ~GEN7_DOP_CLOCK_GATE_ENABLE);
        I915_WRITE(GEN8_L3SQCREG1, BDW_WA_L3SQCREG1_DEFAULT);
+       /*
+        * Wait at least 100 clocks before re-enabling clock gating. See
+        * the definition of L3SQCREG1 in BSpec.
+        */
+       POSTING_READ(GEN8_L3SQCREG1);
+       udelay(1);
        I915_WRITE(GEN7_MISCCPCTL, misccpctl);
 
        /*